Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable $config_director_dirs with purge option #43

Merged
merged 1 commit into from
Dec 24, 2019
Merged

configurable $config_director_dirs with purge option #43

merged 1 commit into from
Dec 24, 2019

Conversation

benibr
Copy link
Contributor

@benibr benibr commented Jun 25, 2019 •
edited
Loading

So I added the $config_director_dirs parameter to the bareos::director class as mentioned in #42 and removed the recurse from the bareos class in order allow directories not managed by puppet.

@benibr benibr force-pushed the feature/config_director_dirs branch 2 times, most recently from be2dc94 to 6e4069a Compare June 25, 2019 15:47
@benibr
Copy link
Contributor Author

benibr commented Sep 2, 2019

So this is a first WIP which works for me. I added the director_managed_dirs variable which can be filled from hiera and defaults to the folders which were created by the module before.

The directories in director_managed_dirs set to be purged by puppet as before, other directories are ignored.

Is this a acceptable concept? I'd like to get some feedback before I continue with specs and stuff

ekohl
ekohl reviewed Nov 22, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the actual purging since I don't know bareos so I'll just comment on the Puppet language comments.

manifests/director.pp Outdated Show resolved Hide resolved
manifests/director.pp Outdated Show resolved Hide resolved
@benibr benibr force-pushed the feature/config_director_dirs branch 4 times, most recently from c091775 to 03b6d8c Compare November 29, 2019 16:17
@benibr
Copy link
Contributor Author

benibr commented Nov 29, 2019

So now the tests for puppet 3 are failing as expected. working around this to support puppet3 would be a pain in 2020.
The change itself works!

@bastelfreak
Copy link
Member

The puppet 3 tests are enabled by accident. We don't support it anymore. Can you please remove the related tests in the .travis.yml?

@benibr benibr force-pushed the feature/config_director_dirs branch 2 times, most recently from 4e45132 to 72e9d38 Compare December 3, 2019 06:25
@benibr
Copy link
Contributor Author

benibr commented Dec 3, 2019

Done. All checks green now.

@benibr
Copy link
Contributor Author

benibr commented Dec 16, 2019

Since the default behaviour does not change and the parameters of director.pp are not in the readme no further documentation is needed imho

@benibr benibr force-pushed the feature/config_director_dirs branch from 665a214 to 57eea0e Compare December 24, 2019 19:35
added code for managed directories
bf525d9 
additionally removed pp3.x from travis CI
@benibr benibr force-pushed the feature/config_director_dirs branch from 57eea0e to bf525d9 Compare December 24, 2019 19:42
@bastelfreak bastelfreak added the enhancement New feature or request label Dec 24, 2019
@bastelfreak bastelfreak merged commit 9aba56f into voxpupuli:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benibr @bastelfreak @ekohl